I guess I see things a little different then the above commenters. I just so happen to have two old OMC/Johnson metal 6 gallon gas tanks. And they are in remarkably good condition without any rust inside or out to speak of. And since they don't have any dents either, I am going to refurbish them and actually use one for my boat tank. There are very solid and don't leak and perfect for my setup. So If you own one, give it a rebuild and use it. They are good tanks. JMHO!
+1
If the old tank is rusty on the inside, throw it away. If its rusty on the outside, spray it with some Rustreformer and call it good. Parts are available for all of them (gaskets, O-rings, etc.) so if they are taken care of they will last forever. They are self-venting, so they are environmentally friendly as well.
The plastic tanks expand and contract with temperature. The gauges suck. Eventually they seep at the fittings, and not really repairable,
Personally I have thrown away 6 year old plastic tanks, while i still run a metal one from 1952. Do the math. I admit the oldie was rebuilt with new gaskets and hose, but the cost of that was less than a new tank.
If you like plastic, go with it, but don't say metal is no good.