99% of the time on a battery w/ 12+ volts, if the lights are on and you hit the starter and get a click, and lights go off, it's a battery connection (or very commonly, the grounding lead between the battery, block and / or the body), or a severely shorted battery.
Put a meter on the battery...